Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification channel): add new notification channel types #389

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

dbonf
Copy link
Collaborator

@dbonf dbonf commented Aug 3, 2023

add new notification channel resources for monitor and secure:

  • sysdig_monitor_notification_channel_google_chat
  • sysdig_monitor_notification_channel_prometheus_alert_manager
  • sysdig_monitor_notification_channel_team_email
  • sysdig_monitor_notification_channel_custom_webhook
  • sysdig_monitor_notification_channel_ibm_event_notification
  • sysdig_monitor_notification_channel_ibm_function
  • sysdig_secure_notification_channel_prometheus_alert_manager
  • sysdig_secure_notification_channel_team_email

@dbonf dbonf force-pushed the new-notification-channels branch 11 times, most recently from ed93948 to 1db8342 Compare August 7, 2023 14:27
@dbonf dbonf marked this pull request as ready for review August 7, 2023 14:29
@dbonf dbonf changed the title feat(notification channel): add notification channels types feat(notification channel): add notification channel types Aug 7, 2023
@dbonf dbonf changed the title feat(notification channel): add notification channel types feat(notification channel): add new notification channel types Aug 7, 2023
@dbonf dbonf force-pushed the new-notification-channels branch 3 times, most recently from 1327243 to f9b2078 Compare August 9, 2023 06:35
@dbonf dbonf force-pushed the new-notification-channels branch from f9b2078 to 343a0ab Compare August 9, 2023 08:14
Copy link
Collaborator

@filiptubic filiptubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM_EVENT_NOTIFICATION_INSTANCE_ID is created under secrets. LGTM just change the github actions to use this new secret.

* sysdig_monitor_notification_channel_google_chat
* sysdig_monitor_notification_channel_prometheus_alert_manager
* sysdig_monitor_notification_channel_team_email
* sysdig_monitor_notification_channel_custom_webhook
* sysdig_monitor_notification_channel_ibm_event_notification
* sysdig_monitor_notification_channel_ibm_function
* sysdig_secure_notification_channel_prometheus_alert_manager
* sysdig_secure_notification_channel_team_email
@dbonf dbonf force-pushed the new-notification-channels branch from 343a0ab to 84ebde5 Compare August 9, 2023 10:32
@dbonf dbonf merged commit 62ec437 into master Aug 9, 2023
23 checks passed
@dbonf dbonf deleted the new-notification-channels branch August 9, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants